[Webkit-unassigned] [Bug 37722] Allow to construct HashTraits<WebCore::QualifiedName>::constructDeletedValue

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37722





--- Comment #14 from anton muhin <antonm at chromium.org>  2010-04-23 09:29:38 PST ---
(In reply to comment #12)
> (From update of attachment 54161 [details])
> > +    ASSERT(!isHashTableDeletedValue()); // HashTableDeletedValue values must be never derefed..
> 
> There's an extra period here. Also, the comment says the same thing as the
> assertion, so I suggest just leaving the comment out.
> 
> I'm going to say r=me, but I am wondering how you tested this change, given the
> old wrong version you had here before.

Comment removed.

I too dissatisfied with the testing I can currently do, that's why I asked if
there are any unit tests in WebKit.

Current patch is tested by running run-webkit-tests on MBP in both debug and
release versions.

Previous version of patch (one that used NULL as a marker for deleted object)
got better testing as it was embedded into NodeList caching benchmark which
indeed exercises removal of elements from maps keyed by QualifiedName.

If you could suggest any testing method I should use, I'd be happy to run it
too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.