[Webkit-unassigned] [Bug 38047] New: svn-apply: suppress misleading "error: pathspec ..." message when adding binary file

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38047

           Summary: svn-apply: suppress misleading "error: pathspec ..."
                    message when adding binary file
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: cjerdonek at webkit.org


See here for an example of the misleading "error: pathspec" message:

https://bugs.webkit.org/show_bug.cgi?id=37044#c12

To solve this, console output should be suppressed in this method of svn-apply:

sub scmKnowsOfFile($)
{
    my ($path) = @_;
    if (isSVN()) {
    ...
    } elsif (isGit()) {
        `git ls-files --error-unmatch -- $path`; <-- Suppress console output.
        my $exitCode = $? >> 8;
        return $exitCode == 0;
    }
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.