[Webkit-unassigned] [Bug 37722] Allow to construct HashTraits<WebCore::QualifiedName>::constructDeletedValue

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 23 09:09:56 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37722


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54161|review?                     |review+
               Flag|                            |




--- Comment #12 from Darin Adler <darin at apple.com>  2010-04-23 09:09:55 PST ---
(From update of attachment 54161)
> +    ASSERT(!isHashTableDeletedValue()); // HashTableDeletedValue values must be never derefed..

There's an extra period here. Also, the comment says the same thing as the
assertion, so I suggest just leaving the comment out.

I'm going to say r=me, but I am wondering how you tested this change, given the
old wrong version you had here before.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list