[Webkit-unassigned] [Bug 37820] Web Inspector: Aggregated time stats should be visible in Timeline record Popup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 23 08:24:01 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37820


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54160|review?                     |review+
               Flag|                            |




--- Comment #8 from Pavel Feldman <pfeldman at chromium.org>  2010-04-23 08:24:02 PST ---
(From update of attachment 54160)
r+ with comments. please address them prior to landing.

WebCore/inspector/InspectorTimelineAgent.cpp:59
 +      if (m_gcEvents.size()) {
Replace with guard expression?

WebCore/inspector/front-end/TimelinePanel.js:1005
 +      _calculateAggregatedStats: function(categories)
It would be great to remove the 0.00001 hack and to do as much of this as
possible lazily (i.e. only calculate self time on record add).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list