[Webkit-unassigned] [Bug 37983] Add RVCT support for Linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37983


Laszlo Gombos <laszlo.1.gombos at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54053|review?                     |review-
               Flag|                            |




--- Comment #3 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2010-04-23 07:35:09 PST ---
(From update of attachment 54053)
Looks good to me, except one merge conflict that needs to be addressed.

> diff --git a/JavaScriptCore/wtf/MathExtras.h b/JavaScriptCore/wtf/MathExtras.h
> index a0c7466..2bf2dd3 100644
> --- a/JavaScriptCore/wtf/MathExtras.h
> +++ b/JavaScriptCore/wtf/MathExtras.h
> @@ -188,7 +188,7 @@ inline float deg2turn(float d) { return d / 360.0f; }
>  inline float rad2grad(float r) { return r * 200.0f / piFloat; }
>  inline float grad2rad(float g) { return g * piFloat / 200.0f; }
>  
> -#if !COMPILER(MSVC) && !COMPILER(RVCT) && !OS(ANDROID) && !COMPILER(WINSCW)
> +#if !COMPILER(MSVC) && !OS(ANDROID) && !COMPILER(WINSCW) && !(COMPILER(RVCT) && OS(SYMBIAN))
>  using std::isfinite;
>  using std::isinf;
>  using std::isnan;

!OS(ANDROID) test has been removed - see
http://trac.webkit.org/changeset/58142.

r-, just to make this small change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.