[Webkit-unassigned] [Bug 36394] Include git commits in the diff for webkit-patch upload/land.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36394


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53904|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #58 from Adam Barth <abarth at webkit.org>  2010-04-23 01:18:34 PST ---
(From update of attachment 53904)
WebKitTools/Scripts/webkitpy/common/checkout/scm.py:181
 +      def changed_files(self, git_commit=None, squash=None):
Should this be squash=False?

WebKitTools/Scripts/webkitpy/common/checkout/api.py:131
 +              raise ScriptError(message="Working directory must be clean to
revert a revision.")
Why did you add this error handling here?  This is the wrong layer to catch
this error.  Notice that apply patch doesn't have a similar check even though
it has logically the same issue.

Thanks for sticking with this patch.  I didn't understand the gut part, but I
appreciate the tests and the effort you put into it.  Eric should review this
change, but he's been slacking off in this department.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.