[Webkit-unassigned] [Bug 38030] Add WebCore::dumpTextEncodingNameMap() to dump text encoding map on debug builds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38030





--- Comment #2 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2010-04-22 21:37:35 PST ---
(In reply to comment #1)
> Attachment 54127 [details] did not pass style-queue:
> 
> Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
> WebCore/platform/text/TextEncodingRegistry.cpp:331:  Tests for true/false,
> null/non-null, and zero/non-zero should all be done without equality
> comparisons.  [readability/comparison_to_zero] [5]
> Total errors found: 1 in 3 files

+        if (++i % 400 == 0)

Would this really read better as:

+        if (!(++i % 400))

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.