[Webkit-unassigned] [Bug 37845] [chromium] new-run-webkit-tests --use-drt should run on Linux
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 22 17:58:36 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=37845
--- Comment #6 from Tony Chang (Google) <tony at chromium.org> 2010-04-22 17:58:36 PST ---
(In reply to comment #4)
> (From update of attachment 53788 [details])
> WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_mac.py:91
> + def results_directory(self):
> Why is this code copy/pasted twice? It seems better to have it in the base
> class if its used by more than one subclass.
I copied the functions because they call _build_path() which is only defined in
the implementation classes. But I see other methods doing this, so I guess
that's ok.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list