[Webkit-unassigned] [Bug 38016] New: Update padding on Windows?

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 22 17:38:24 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38016

           Summary: Update padding on Windows?
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ojan at chromium.org
                CC: hyatt at apple.com, adele at apple.com, mitz at webkit.org,
                    hamaji at chromium.org


In bug 35629, Chromium removed the extra internal padding on buttons since it
was causing compatibility problems. So far we've gotten no compatibility bugs
filed, but we have had a few complaints that buttons look ugly. Through some
discussion with people complaining, it looks like adding back in the 1px of
top/bottom padding will meet their needs without adding a compatibility hit.

I propose that we get rid of the internal button padding on Windows (and thus
the need for a concept of internal button padding) and instead add the
following to themeWin.css, which increases padding-top/bottom by 1px from
what's in html.css:
input[type="button"], input[type="submit"], input[type="reset"],
input[type="file"]::-webkit-file-upload-button, button {
    padding-top: 3px;
    padding-bottom: 4px;
}

This will minimize compatibility problems without making the buttons look
awful.

That sound OK to you all?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list