[Webkit-unassigned] [Bug 37874] Provide mechanism to cache metadata for a resource

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37874


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54091|review?                     |review-
               Flag|                            |




--- Comment #7 from Adam Barth <abarth at webkit.org>  2010-04-22 14:13:14 PST ---
(From update of attachment 54091)
WebCore/loader/CachedResource.cpp:168
 +  void CachedResource::setCachedMetadata(CacheableMetadata::Type type,
PassRefPtr<SharedBuffer> data, FrameLoader* frameLoader)
Why pass a FrameLoader* here?  Usually we pass around Frame*.

WebCore/loader/CachedResource.cpp:175
 +      if (frameLoader && frameLoader->client())
client() is always non-NULL.

WebCore/loader/CachedResource.h:148
 +      void setCachedMetadata(CacheableMetadata::Type,
PassRefPtr<SharedBuffer>, FrameLoader*);
Does CachedResource have any other dependencies on Frame?  In general, we want
the Frame to be less involved in loading, not more.

WebCore/loader/FrameLoaderClient.h:47
 +      struct CacheableMetadata;
We prefer classes to structs.

WebCore/platform/network/ResourceResponseBase.h:48
 +      long long m_id;
This whole thing is very strangely layered.  In WebKit, there's no necessary
connection between the client and the networking layer.  This patch somehow
assumes some strange round-tripping between the two.

Why is the client involved in this process at all?  It seems like WebCore
should just ask the networking layer to cache these bytes.

WebCore/platform/network/ResourceResponseBase.h:52
 +          V8_SCRIPTDATA
Code in this location isn't allowed to know about V8.  We need a better way of
assigning these type numbers.  Also, are these number persisted on disk?  We
might need some comments explaining the rules for modifying these bits.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.