[Webkit-unassigned] [Bug 37508] [Haiku] Rework FontPlatformData implementation

Thu Apr 22 12:55:27 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=37508

--- Comment #6 from Stephan Aßmus <superstippi at gmx.de>  2010-04-22 12:55:27 PST ---
Thanks a lot for the review.

* The patch should be UTF-8 encoded. Once my patches land, the name is
displayed correctly (IIRC). I could write "Assmus" which is almost equivalent
in German, but I thought I could use the correct spelling "Aßmus".

* The "// #pragma mark -" is just a directive for the editor which most Haiku
devs are using, it causes a separator in the symbol popup menu improving
clarity. No problem to remove it if this is inappropriate.

* Please advice what is appropriate for the hashTableDeletedValue, I just took
this solution from the Qt port. The manual reference counting too, btw. ;-)

Will try to address the rest of your review points ASAP. Thanks again!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.