[Webkit-unassigned] [Bug 37845] [chromium] new-run-webkit-tests --use-drt should run on Linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37845


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53788|review?                     |review-
               Flag|                            |




--- Comment #4 from Adam Barth <abarth at webkit.org>  2010-04-22 12:51:17 PST ---
(From update of attachment 53788)
WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_mac.py:91
 +      def results_directory(self):
Why is this code copy/pasted twice?  It seems better to have it in the base
class if its used by more than one subclass.

WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_mac.py:167
 +      def _path_to_image_diff(self):
This code looks copy/pasted too.

WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_win.py:101
 +      def results_directory(self):
Here the code is again.  We don't want any copy/paste code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.