[Webkit-unassigned] [Bug 37518] new-run-webkit-websocketserver failed to launch on Win

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37518


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54042|review?                     |review-
               Flag|                            |




--- Comment #3 from Adam Barth <abarth at webkit.org>  2010-04-22 12:29:00 PST ---
(From update of attachment 54042)
WebKitTools/Scripts/webkitpy/layout_tests/port/server_process.py:46
 +      from win32pipe import PeekNamedPipe
Can we abstract this functionality into some kind of library instead of having
these ifs all over the place?

WebKitTools/Scripts/webkitpy/layout_tests/port/server_process.py:83
 +              fd = self._proc.stdout.fileno()
Please use more verbose variable names.  I have no idea what this code is
doing.

WebKitTools/Scripts/webkitpy/layout_tests/port/server_process.py:206
 +      def _select(self, rlist, wlist, xlist, timeout):
Again, these argument names are incomprehensible.

WebKitTools/Scripts/webkitpy/layout_tests/port/server_process.py:222
 +              time.sleep(0.1)
Do we really need this sleep loop?  This seems janky.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.