[Webkit-unassigned] [Bug 37997] [EFL] Update EWebKit to match recent API changes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37997


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54074|review?                     |review-
               Flag|                            |




--- Comment #2 from Gustavo Noronha (kov) <gns at gnome.org>  2010-04-22 11:01:49 PST ---
(From update of attachment 54074)
 1845 #if 0
18361846     WTF::RefPtr<WebCore::PluginView> pluginView =
WebCore::PluginView::create
18371847         (sd->frame, pluginSize, element, url, paramNames, paramValues,
18381848          mimeType, loadManually);
18391849 
18401850     if (pluginView->status() ==
WebCore::PluginStatusLoadedSuccessfully)
18411851         return pluginView;
 1852 #endif
18421853 

It's not usual to have code ifdefed/commented out in WebKit, and it looks like
this change should go separately?

991      sd->frame->setZoomFactor(zoom, sd->zoom_text_only);
 991     WebCore::ZoomMode zoomMode;
 992     if (sd->zoom_text_only)
 993         zoomMode = WebCore::ZoomTextOnly;
 994     else
 995         zoomMode = WebCore::ZoomPage;
 996     sd->frame->setZoomFactor(zoom, zoomMode);

Just to be clear, this was WebCore going from boolean to an enum?

r- because of the first issue

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.