[Webkit-unassigned] [Bug 37977] [Chromium] Font size in suggestions popup menu should be correlated with the font size of its text field.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37977


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54064|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #8 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2010-04-22 09:10:53 PST ---
(From update of attachment 54064)
> Index: ChangeLog
> ===================================================================
> --- ChangeLog	(revision 58098)
> +++ ChangeLog	(working copy)
> @@ -1,3 +1,18 @@
> +2010-04-22  Roman Gershman  <romange at google.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +	[Chromium] Font size in suggestions popup menu should be correlated with the font size of its text field.
> +	Currently it's not possible to test this change via LayoutTests,
> +	since test_shell does not implement suggestions popup.

The diff for the ChangeLog is touches way too much. Can you please reduce that?

>          Unreviewed, rolling out r58069.
> Index: src/SuggestionsPopupMenuClient.cpp
> ===================================================================
> --- src/SuggestionsPopupMenuClient.cpp	(revision 58097)
> +++ src/SuggestionsPopupMenuClient.cpp	(working copy)
> @@ -156,11 +156,9 @@ void SuggestionsPopupMenuClient::initial
>      FontDescription fontDescription;
>      RenderTheme::defaultTheme()->systemFont(CSSValueWebkitControl,
>                                              fontDescription);
> +    RenderStyle* style = m_textField->computedStyle();
> +    fontDescription.setComputedSize(style->fontDescription().computedSize());

... but we can write a unit test for this, right?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.