[Webkit-unassigned] [Bug 37848] WCSS: -wap-input-format and -wap-input-required not supported.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37848





--- Comment #5 from Charles Wei <charles.wei at torchmobile.com.cn>  2010-04-22 03:51:57 PST ---
(In reply to comment #3)
> (From update of attachment 53930 [details])
> 
> > +#if ENABLE(WCSS)
> > +void HTMLInputElement::setWapInputFormat(String& mask)
> > +{
> > +    String validateMask = validateInputMask(m_data, mask);
> > +    if (!validateMask.isEmpty())
> > +        m_data.setInputFormatMask(validateMask);
> > +}
> > +#endif
> 
> I think the argument to this function should be const.

====> mask can't be const, because we need to change it inside the function 

> 
> > +    virtual InputElementData data() { return m_data; }
> 
>  These functions should probably be const?
> 
====> Fixed with the new patch.
> 
> 
> The rest looks good.  r- for those two minor fixes, then r+ if no concerns from
> others between now and morning.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.