[Webkit-unassigned] [Bug 37979] [chromium] fix ImageDiff compile on windows

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 22 01:03:25 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37979





--- Comment #4 from Tony Chang (Google) <tony at chromium.org>  2010-04-22 01:03:25 PST ---
(In reply to comment #2)
> (From update of attachment 54035 [details])
> > --- a/WebKitTools/DumpRenderTree/chromium/ImageDiff.cpp
> > +++ b/WebKitTools/DumpRenderTree/chromium/ImageDiff.cpp
> > @@ -39,12 +39,15 @@
> >  #include "gfx/codec/png_codec.h"
> >  #include <algorithm>
> >  #include <stdio.h>
> > -#include <string.h>
> > -#include <string>
> >  #include <vector>
> 
> strcmp() is used. We had better not remove string.h.

Good catch.  Attempting to land the revised patch now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list