[Webkit-unassigned] [Bug 37848] WCSS: -wap-input-format and -wap-input-required not supported.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37848


George Staikos <staikos at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53930|review?                     |review-
               Flag|                            |




--- Comment #3 from George Staikos <staikos at kde.org>  2010-04-21 23:11:54 PST ---
(From update of attachment 53930)

> +#if ENABLE(WCSS)
> +void HTMLInputElement::setWapInputFormat(String& mask)
> +{
> +    String validateMask = validateInputMask(m_data, mask);
> +    if (!validateMask.isEmpty())
> +        m_data.setInputFormatMask(validateMask);
> +}
> +#endif

I think the argument to this function should be const.

> +    virtual InputElementData data() { return m_data; }

 These functions should probably be const?



The rest looks good.  r- for those two minor fixes, then r+ if no concerns from
others between now and morning.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.