[Webkit-unassigned] [Bug 37939] Fix PluginViewNone.cpp compilation for ports that also compile PluginView.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37939





--- Comment #3 from Kevin Ollivier <kevino at theolliviers.com>  2010-04-21 18:25:46 PST ---
(In reply to comment #2)
> (From update of attachment 53990 [details])
> > +// FIXME: PluginViewNone.cpp should be a drop-in stubs file for a port's 
> > +// PluginView<Port>.cpp file and should only contain port-specific methods. 
> > +// These three APIs in the PLATFORM(MAC) block are not port-specific and 
> > +// are only here because the Mac port wishes not to compile PluginView.cpp, 
> > +// where the implementations for these methods live. Note also that it does not
> > +// need any of the other method stubs in this file. These functions probably
> > +// belong in a Mac-specific file somewhere.
> 
> This wall of text is confusing!
> 
> Can you do something better so you don't have to check this in?

I'm open to suggestions, but the fact that these methods are defined in this
file is the source of the confusion, and if we're to avoid similar breakages in
the future, we need to make sure people are clear about what the Mac port is
using this file for and how it differs from what everyone else is using this
file for. 

To avoid this approach, the three methods in this file needed by Mac need to
either go somewhere else (if so, where?) or we need to search the codebase for
the calls to these three methods and preface them with #if !PLATFORM(MAC). Any
thoughts / preferences? I'm open to any ideas that fix this right so that
people don't keep adding more stubbed versions of methods from PluginView.cpp
into this file (which will break compilation for pretty much any other port
using it).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.