[Webkit-unassigned] [Bug 37837] [chromium] Select popups should be closed when the browser window is moved/resized.

Wed Apr 21 14:58:57 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=37837

Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53758|review?                     |review-
               Flag|                            |

--- Comment #2 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-04-21 14:58:57 PST ---
(From update of attachment 53758)
> Index: WebKit/chromium/public/WebView.h

> -    // DEPRECATED: WebView::hideSuggestionsPopup is the new way to access this.
> -    virtual void hideAutofillPopup() = 0;
> -
> -    // Hides the suggestions popup if any are showing.
> -    virtual void hideSuggestionsPopup() = 0;
> +    // Hides any popup (suggestions, selects...) that might be showing.
> +    virtual void hidePopups() = 0;

Won't this break Chromium when it is committed?  Can you preserve the old
method(s) until Chromium is switched over to only calling hidePopups?  Then
circle back with a cleanup patch to remove the DEPRECATED methods.

Otherwise, LGTM

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.