[Webkit-unassigned] [Bug 37765] REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 21 13:50:06 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=37765
--- Comment #47 from Eric Seidel <eric at webkit.org> 2010-04-21 13:50:05 PST ---
The file system abstraction is really codecs.open() I learned at the end of
this change that I could have even deployed codecs.open wider.
We should *never* be using open() directly. codecs.open takes an encoding
parameter (just like Python 3.x open() does). encoding=None results in
open()-like, return-a-str-object behavior.
So in a followup patch we should remove all uses of raw open().
We should also avoid ever closing a file manually. Doing so will fail in teh
case of an exception, which is why we use with blocks. :)
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list