[Webkit-unassigned] [Bug 37934] [Qt] QtLauncher: make FPS measurement accurate

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 21 11:01:19 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37934


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-04-21 11:01:20 PST ---
Attachment 53969 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/QtLauncher/fpsmeasure.cpp:28:  Found header this file implements
before WebCore config.h. Should be: config.h, primary header, blank line, and
then alphabetically sorted.  [build/include_order] [4]
WebKitTools/QtLauncher/fpsmeasure.cpp:30:  Alphabetical sorting problem. 
[build/include_order] [4]
WebKitTools/QtLauncher/fpsmeasure.cpp:42:  Missing space after , 
[whitespace/comma] [3]
WebKitTools/QtLauncher/fpsmeasure.h:28:  #ifndef header guard has wrong style,
please use: fpsmeasure_h  [build/header_guard] [5]
WebKitTools/QtLauncher/fpsmeasure.h:33:  Alphabetical sorting problem. 
[build/include_order] [4]
WebKitTools/QtLauncher/fpsmeasure.h:36:  This { should be at the end of the
previous line  [whitespace/braces] [4]
WebKitTools/QtLauncher/fpsmeasure.h:40:  Use 0 instead of NULL. 
[readability/null] [5]
Total errors found: 7 in 6 files


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list