[Webkit-unassigned] [Bug 37909] Call sites of TextIterator constructor are difficult to read

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37909


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53919|review?                     |review+
               Flag|                            |




--- Comment #4 from Darin Adler <darin at apple.com>  2010-04-21 09:34:40 PST ---
(From update of attachment 53919)
>  enum TextIteratorBehavior {
>      TextIteratorBehaviorDefault = 0,
> -    TextIteratorBehaviorEmitCharactersBetweenAllVisiblePositions = 1 << 0,
> -    TextIteratorBehaviorEnterTextControls = 1 << 1,
> +    TextIteratorBehaviorEmitsCharactersBetweenAllVisiblePositions = 1 << 0,
> +    TextIteratorBehaviorEntersTextControls = 1 << 1,
>      TextIteratorBehaviorEmitsTextsWithoutTranscoding = 1 << 2,
>  };

I think these repeat the word "Behavior" too much. I would call these:

    TextIteratorDefaultBehavior = 0,
    TextIteratorEmitsCharactersBetweenAllVisiblePositions = 1 << 0,
    TextIteratorEntersTextControls = 1 << 1,
    TextIteratorEmitsTextWithoutTranscoding = 1 << 2,

r=me, whether or not you change the names

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.