[Webkit-unassigned] [Bug 37801] [v8] Do not pass empty handle into SetHiddenValue which would crash

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37801





--- Comment #9 from anton muhin <antonm at chromium.org>  2010-04-21 05:44:54 PST ---
(In reply to comment #7)
> Maybe an assert so we can catch this in debug builds?  That also documents that
> were not sold on null handles being correct here.

I've attempted to add an assert.

My concerns:

1) if my analysis is correct, we'll just die in debug builds (but benefit is we
could verify the hypothesis)

2) beyond verifying the hypothesis, it won't allow us to understand why it
empty here.

If we want to understand what goes here, I'd inline toV8 method here and see
why we take a branch returning empty handle.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.