[Webkit-unassigned] [Bug 37910] [DRT/Chromium] Import MockSpellCheck from Chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37910





--- Comment #9 from TAMURA, Kent <tkent at chromium.org>  2010-04-21 03:36:46 PST ---
> > +using namespace std;
> 
> Do we still need this?

No.  Removed.

> > +    // Convert to String because WebString doesn't have find*() functions.
> > +    const String text16(text.data(), text.length());
> 
> Is text16 good naming? Also, the comment seems to be stale.

Renamed it to stringText, and updated the comment.

> > +    const char wordCharacters[] = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";
> 
> static const would be better. Also, I think we can use isalpha or something
> instead of this.

Right!  I have changed it to WTF::isASCIIAlpha().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.