[Webkit-unassigned] [Bug 37765] REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37765





--- Comment #45 from Eric Seidel <eric at webkit.org>  2010-04-21 03:35:57 PST ---
I've updated the patch to deploy "codecs.open" everywhere, as per Chris's
suggestion.  While I was looking at every open() call, I converted a bunch of
them to use "with" to avoid file descriptor leaks.

The patch is huge now.  However, it does fix the 3 regressions seen when
landing the last patch:
1. mac-ews was failing due to having changed how --status-host was passed, our
global argument parsing is a hack, at least I've documented that now.
2.  webkit-patch upload was broken for svn users due to the svn-create-patch
call not passing its arguments as an array.
3.  new-run-webkit-tests was broken for chromium due to diff creation logic not
specifying an encoding.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.