[Webkit-unassigned] [Bug 37910] [DRT/Chromium] Import MockSpellCheck from Chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37910


Shinichiro Hamaji <hamaji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53936|review?                     |review-
               Flag|                            |




--- Comment #7 from Shinichiro Hamaji <hamaji at chromium.org>  2010-04-21 03:13:57 PST ---
(From update of attachment 53936)
> +using namespace std;

Do we still need this?

> +    // Convert to String because WebString doesn't have find*() functions.
> +    const String text16(text.data(), text.length());

Is text16 good naming? Also, the comment seems to be stale.

> +    const char wordCharacters[] = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";

static const would be better. Also, I think we can use isalpha or something
instead of this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.