[Webkit-unassigned] [Bug 37909] New: Call sites of TextIterator constructor are difficult to read

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 20 22:59:29 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37909

           Summary: Call sites of TextIterator constructor are difficult
                    to read
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: hamaji at chromium.org


As suggested in Bug 36419, TextIterator and CharacterIterator are instantiated
with confusing boolean parameters. Let's use enum version of their constructor
and eliminate the old constructors.

I'm planning to change the names of boolean members of these classes (e.g.,
m_emitCharactersBetweenAllVisiblePositions). They should be third person
singular.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list