[Webkit-unassigned] [Bug 37903] Added missing #include "Lookup.h" in LUT source files.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37903


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53906|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2010-04-20 17:15:02 PST ---
(From update of attachment 53906)
> Index: JavaScriptCore/runtime/ArrayPrototype.cpp
> ===================================================================
> --- JavaScriptCore/runtime/ArrayPrototype.cpp	(revision 57939)
> +++ JavaScriptCore/runtime/ArrayPrototype.cpp	(working copy)
> @@ -24,13 +24,13 @@
>  #include "config.h"
>  #include "ArrayPrototype.h"
>  
> -#include "CodeBlock.h"
>  #include "CachedCall.h"
> +#include "CodeBlock.h"
>  #include "Interpreter.h"
>  #include "JIT.h"
>  #include "JSStringBuilder.h"
> -#include "ObjectPrototype.h"
>  #include "Lookup.h"

Since ArrayPrototype.h already includes Lookup.h, I don't think
ArrayPrototype.cpp needs to include it at all.

But this is not an argument against the patch. The reason this does not affect
other builds is that most use AllInOneFile.cpp rather than compiling these
files separately.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.