[Webkit-unassigned] [Bug 37232] [Chromium] RTL <select> dropdown box expands to right instead of left

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37232





--- Comment #7 from Xiaomei Ji <xji at chromium.org>  2010-04-20 15:48:16 PST ---
(In reply to comment #5)
> (From update of attachment 52994 [details])
> >
> > +    // Adjust the starting x-axis for RTL dropdown. For RTL dropdown, the right edge
> > +    // of dropdown box should be aligned with the right edge of <select> element box,
> > +    // and the dropdown box should be expanded to left if more space needed.
> > +    bool rightAligned = m_listBox->m_popupClient->menuStyle().textDirection() == RTL;
> 
> Can m_popupClient be 0 here?

I do not think it can be 0 here. But I added a NULL check for safe.

> 
> > +    if (rightAligned)
> > +        move(x() + popupWidth - listBoxWidth, y());
> >  
> >      invalidate();
> >  }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.