[Webkit-unassigned] [Bug 37765] REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37765





--- Comment #41 from Eric Seidel <eric at webkit.org>  2010-04-20 15:14:52 PST ---
(In reply to comment #40)
> (In reply to comment #39)
> > (In reply to comment #38)
> > > So, to summarize the thinking in this patch:
> > > 
> > > 1) assume all text files are encoded on disk as UTF-8
> > 
> > More precisely: be explicit about how things are encoded, whatever that
> > encoding may be.
> > 
> 
> I was (perhaps badly) attempting to be stronger than that. What I meant was,
> previously we had probably assumed that all of the files are ASCII. We don't
> want to assume that, but since we don't want to try and do encoding detection,
> we should probably assume something, and that should probably be UTF-8.

Except they weren't ascii. :)  The exception Chromium hit when this was landed
was due to the diff-processing code trying to write out a unicode string. 
Previously we were blissfully unaware that diff/wdiff/prettypatch were
returning us utf-8 encoded data and we were passing it around as str()s.

After this patch, we convert data returned from commands back into unicode()
strings.  Making some things easier, but requiring us to be explicit about
converting our unicode strings back to byte arrays before writing them out to
files (or using codecs.open to make our write() calls transparently convert).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.