[Webkit-unassigned] [Bug 37765] REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37765





--- Comment #38 from Dirk Pranke <dpranke at chromium.org>  2010-04-20 14:50:39 PST ---
So, to summarize the thinking in this patch:

1) assume all text files are encoded on disk as UTF-8
2) read files using codecs.open(..., "r", encoding="utf-8")
3) write files using codecs.open(..., "w", enocding="utf-8"),
write(s.encode("utf-8")) 
    if s is a string that is not known to be encoded already

Correct?

It would be good if we provided wrappers for (2) and (3) that handled this
automatically and centralized the open and close logic in one place. 

Perhaps the read_file() and write_file() utility routines in dryrun.py that are
supposed to be split off into their own file would be a good start on
standardizing this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.