[Webkit-unassigned] [Bug 37867] [Qt] Patches to upstream from Qt for 2.0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 20 12:12:17 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37867


Tor Arne Vestbø <vestbo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53853|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #14 from Tor Arne Vestbø <vestbo at webkit.org>  2010-04-20 12:12:17 PST ---
(From update of attachment 53853)

> +# Output in JavaScriptCore/<config>
> +CONFIG(debug, debug|release): JAVASCRIPTCORE_DESTDIR = debug
> +CONFIG(release, debug|release): JAVASCRIPTCORE_DESTDIR = release
> +# Use different targets to prevent parallel builds file clashes on Mac
> +CONFIG(debug, debug|release): JAVASCRIPTCORE_TARGET = jscored
> +CONFIG(release, debug|release): JAVASCRIPTCORE_TARGET = jscore

Nit, please combine these into scoped blocks, let's try to avoid repeated
CONFIG(...) all over the place

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list