[Webkit-unassigned] [Bug 37478] Update PluginViewNone and PluginPackageNone to the last Plugin API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37478


Gustavo Sverzut Barbieri <barbieri at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #24 from Gustavo Sverzut Barbieri <barbieri at profusion.mobi>  2010-04-20 10:12:36 PST ---
(In reply to comment #23)
> (In reply to comment #22)
> > The applied patch still does not fix all the issues, if one links
> > PluginView.cpp with PluginViewNone.cpp, it will not work since the following
> > methods are defined in both:
> 
> What port is trying to link both PluginView.cpp and PluginViewNone.cpp? That
> doesn't seem right. I think all ports should either:
> 
> 1) Link PluginViewNone.cpp, or
> 2) Link PluginView.cpp plus PluginViewYourPort.cpp

Well, after your help at IRC, I finally managed to fix it by using just
PluginViewNone.cpp, not requiring PluginView.cpp.  However I had to manually
disable some code paths that would call Plugin* code, like the PluginDatabase
and so on.

Given this, I'm closing this bug. But it would be really good to have
PluginView.cpp to be able to link with PluginViewNone.cpp and the methods would
disable automatically.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.