[Webkit-unassigned] [Bug 37442] [PATCH] [Qt] Fix compilation with system tray disabled.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37442





--- Comment #12 from Chang Shu <Chang.Shu at nokia.com>  2010-04-20 09:59:35 PST ---
> > > contains(DEFINES, QT_NO_SYSTEMTRAYICON):DEFINES += ENABLE_NOTIFICATIONS=0
> > 
> > I don't think the pri file is able to detect if QT_NO_SYSTEMTRAYICON is
> > defined.
> 
> Chang, you're right that unless QT_NO_SYSTEMTRAYICON is explicitly listed in
> the DEFINES qmake will not pick it up as it is only defined in a Qt header.
> 
> A compromise would be not to disable the ENABLE_NOTIFICATIONS feature but only
> guard the SysTray dependent code with SYSTEMTRAYICON. I think in the future we
> should allow QtWebKit clients to render the notification themselves.

I agree to guard the systemtrayicon code as we don't have a general solution
and in this case, it's even a better solution as you have indicated for future
enhancement. I am working on a patch if you guys don't mind.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.