[Webkit-unassigned] [Bug 37719] Some HTML5 Input tags not treated as needing an input method.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37719


Julien Chaffraix <jchaffraix at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |jchaffraix at webkit.org
     Ever Confirmed|0                           |1




--- Comment #6 from Julien Chaffraix <jchaffraix at webkit.org>  2010-04-20 09:34:16 PST ---
> Having not submitted to WebKit before, I wasn't sure if I should provide only
> the minimal fix meeting our style guidelines, or a larger patch file that also
> addresses existing style errors in the file before I came along. This patch has
> both the fix for the issue & fixes for all style problems found by
> check-webkit-style.

I really depends on reviewers. Some prefer to leave the style change for
another one (it makes the diff difficult to read), other prefer to do them as
you go (and avoid clobbering git/svn blame).

Just a few comments, your change would definitely like to have an updated
version of the ChangeLog to mention which methods are modified and which are
just put to the right style. I had a really hard time seeing your change among
the style noise.

Also make sure you set r? to all patches you want reviewers to look at and not
just the first one. Make sure you obsolete the old patches so that they are not
reviewed in lieu of the latest one.

And welcome to WebKit!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.