[Webkit-unassigned] [Bug 37478] Update PluginViewNone and PluginPackageNone to the last Plugin API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37478


Gustavo Sverzut Barbieri <barbieri at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |




--- Comment #22 from Gustavo Sverzut Barbieri <barbieri at profusion.mobi>  2010-04-20 07:39:03 PST ---
Hi all,

The applied patch still does not fix all the issues, if one links
PluginView.cpp with PluginViewNone.cpp, it will not work since the following
methods are defined in both:

 * void PluginPackage::determineQuirks(const String& mimeType);
 * void PluginView::keepAlive(NPP instance);
 * void PluginView::setJavaScriptPaused(bool paused);
 * void PluginView::privateBrowsingStateChanged(bool privateBrowsingEnabled);

If we remove these from Plugin*None.cpp as we suggested before, it will not
work on Mac/XCode as it will not link PluginView.cpp, just PluginViewNone.cpp
and thus the error.

I see two options:
 1. Link Mac with PluginView.cpp, but needs someone from Mac to review;
 2. ifdef these functions in PluginViewNone.cpp to just provide them if
platform is MAC, or not XP_UNIX...

I guess the first is more correct, but I'm not aware of the side effects.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.