[Webkit-unassigned] [Bug 37198] [Qt] Interrupting JavaScript is cumbersome when you use QtLaucher for testing or profiling.

Mon Apr 19 17:40:15 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=37198

Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52867|review?                     |review+
               Flag|                            |

--- Comment #5 from Simon Hausmann <hausmann at webkit.org>  2010-04-19 17:40:15 PST ---
(From update of attachment 52867)
r+, but I think you can remove

+    WebPage(QObject* parent = 0, bool interruptingJavaScriptEnabled = false);

as you don't seem to call the constructor with that argument.

I'm generally not a fan of boolean arguments that make the caller code harder
to read,

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.