[Webkit-unassigned] [Bug 37797] DRT should exit(1) to avoid ReportCrash starting

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 19 17:24:40 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37797





--- Comment #3 from Ojan Vafai <ojan at chromium.org>  2010-04-19 17:24:39 PST ---
(In reply to comment #2)
> Can someone clarify why this should be the default?  If I make a code change,
> run the tests, and it causes a crash or assertion failure I want to know where
> it crashed or asserted.  In what cases would you not want to know where or why
> it crashed?

Maybe I'm the exception, but when I hit a crash or assert running tests, I
typically will run that specific test directly from xcode rather than looking
at the crash log. The only exception to this is if the crash doesn't happen
reliably, in which case I'd be ok with turning crash reporting on.

Making this the default makes hacking on webkit more inviting to new or
occasional contributors. People who don't regularly hack on Macs and/or
WebKit-Mac, don't remember that ReportCrash exists and that it considerably
slows down running the tests.

Also, it's not uncommon for there to be crashes checked in to trunk. I don't
want run-webkit-tests to take forever because someone else's patch is causing a
handful of crashes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list