[Webkit-unassigned] [Bug 37793] [Chromium] new-run-webkit-tests should use WebKitDriver for --use-drt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37793





--- Comment #7 from Dirk Pranke <dpranke at chromium.org>  2010-04-19 10:36:40 PST ---
(In reply to comment #2)
> (From update of attachment 53659 [details])
> User.open_url is probably better than calling webbrowser directly:
> http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/system/user.py#L81
> it allows us to more easily mock out this code for testing.
> 
> This is a rather strange class inversion.  I guess eventually Chromium will be
> a subclass of WebKitPort.

If this were to become the case, then WebKitPort should probably be merged into
port/base.py. It is useful to think of base.py as declaring an interface, but
it really is a base class. The only other implementations that wouldn't inherit
from WebKitPort would be the testing/mock classes, and they can override
whatever they need do.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.