[Webkit-unassigned] [Bug 37731] Integrate v8 testing utility with webkit tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37731





--- Comment #7 from Yaar Schnitman <yaar at chromium.org>  2010-04-19 10:21:15 PST ---
(In reply to comment #4)
> (From update of attachment 53571 [details])
> + os.system(' '.join(cmd))
> 
> os.system is a dangerous API.  Please consider using popen or
> webkitpy.common.system.executive.
Fixed to use subprocess.call

> + webkitRoot = os.path.join(os.path.dirname(__file__), '..', '..')
> 
> This seems very fragile.  Please consider using checkout_root in
> webkitpy.common.checkout.scm.
Fixed.
> 
> + workDir = tempfile.mkdtemp()
> 
> I don't understand why we need a working temp directory.  Can't we just
> generate the new output into a memory buffer?
There are 3 reasons:
1) Its hard to run 'diff' on a memory buffer.
2) Its hard to predict pipe the output of the Perl generator into a memory
buffer, as there is no agreed interface for how many files and what files it
outputs. While I can hard code something for V8, I want this to generalize to
other generators.
3) Its shorter, simpler code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.