[Webkit-unassigned] [Bug 37736] new-run-webkit-tests output is different from (and worse than) original run-webkit-tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 19 07:45:37 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37736





--- Comment #11 from Adam Roben (aroben) <aroben at apple.com>  2010-04-19 07:45:35 PST ---
(In reply to comment #10)
> (In reply to comment #9)
> > That's really nice btw.  I'm not sure we really want to kill wdiff.  We
> > shouldn't show the "wdiff" link on platforms which don't have wdiff installed
> > however. :)
> 
> Ideally we'd use wdiff it's available and pretty-patch otherwise, since wdiff
> output is a bit better. I don't think there are any cases where you actually
> want both.

We could change PrettyPatch to create wdiff-like output in the cases where it
currently shows intra-line diffs. Maybe we'd want this to be a special mode for
PrettyPatch, though, as there are some cases where I think that would be
undesirable (e.g., when changing a comment in C++ code and re-wrapping the
comment lines).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list