[Webkit-unassigned] [Bug 37797] New: DRT should exit(1) to avoid ReportCrash starting

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 19 07:10:40 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37797

           Summary: DRT should exit(1) to avoid ReportCrash starting
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ojan at chromium.org
                CC: eric at webkit.org, mjs at apple.com


>From bug 37738:
> > > Also, is there a way we can kill ReportCrash from NRWT? When I run the tests
> > > locally, I frequently will "sudo killall ReportCrash" in a loop. I'd much
> > > rather have NRWT do that for me. The sudo is the problem of course.
> > 
> > I don't think that would be a good thing to do. The crash logs are very useful
> > for diagnosing what went wrong, especially on the buildbots.
> 
> I've long wanted such an option to run-webkit-tests.  It's easy enough to do.
> Just requires adding a flag to DumpRenderTree to have it catch the necessary
> signals and exit(1) instead of letting the OS catch them for us and calling
> ReportCrash.  I don't think we'd want this mode on by default, but it would be
> useful.

I think we should make it the default and have a flag to turn it off on the
bots. Also, we do this with TestShell on the Mac. It reduces the number of
cases where ReportCrash fires up, but doesn't seem to catch all of them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list