[Webkit-unassigned] [Bug 35607] Allow building smoothly on win32 and win64 using GCC

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 18 11:19:23 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=35607


vanboxem.ruben at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52433|0                           |1
        is obsolete|                            |
  Attachment #52433|commit-queue?               |
               Flag|                            |
  Attachment #53630|                            |review?, commit-queue?
               Flag|                            |




--- Comment #55 from vanboxem.ruben at gmail.com  2010-04-18 11:19:21 PST ---
Created an attachment (id=53630)
 --> (https://bugs.webkit.org/attachment.cgi?id=53630)
WebCore patch for mingw-w64

npapi.h: uint32 is not correct for lparam and wparam on WIN64 (see links
below). Nothing changes for existing 32-bit code or other platforms.
Arena.h: pointers need to be cast to 64-bit types, uintptr_t handles platform
and bitness differences nicely
TexStream.*: int64 needs to be used on all WIN64 platforms, not just msvc
PluginView.cpp: cast to LONG_PTR instead of LONG (see link below)
PluginViewWin.cpp: fix pointer casts (this change is now reflected in npapi.h)

MSDN:
(64-bit guidelines)
http://msdn.microsoft.com/en-us/library/aa384242%28v=VS.9%29.aspx
(LONG_PTR)
http://msdn.microsoft.com/en-us/library/aa383751%28VS.9%29.aspx
Intel (WPARAM, LPARAM, see point 5):
http://software.intel.com/en-us/articles/seven-steps-of-migrating-a-program-to-a-64-bit-system/

I hope this is enough to convinve everyone :) Otherwise I'd be happy to
elaborate.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list