[Webkit-unassigned] [Bug 20219] Databases pane doesn't recognize table creation/deletion

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20219


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53610|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org>  2010-04-17 15:18:39 PST ---
(From update of attachment 53610)
Looks good. I haven't actually tried it locally yet but it looks simple enough.
Some minor issues that would need to be fixed in order for this to get
accepted.


> +2010-04-17  Juan C. Montemayor  <jmonte03 at cs.tufts.edu>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Bug 20219 - Databases pane doesn't recognize table creation/deletion
> +        https://bugs.webkit.org/show_bug.cgi?id=20219

Nit: prepare-ChangeLog should not have added the "Bug 20219" part, because the
link itself has that. You can remove that text.


>      _queryFinished: function(query, result)
>      {
>          var dataGrid = WebInspector.panels.storage.dataGridForResult(result);
> -        if (!dataGrid)
> -            return;
> +        
> +        if(dataGrid){
>          dataGrid.element.addStyleClass("inline");
>          this._appendQueryResult(query, dataGrid.element);
>          dataGrid.autoSizeColumns(5);
> +        }

The code inside the if should be indented (4 spaces) as per the style
guidelines:
http://webkit.org/coding/coding-style.html


>          if (query.match(/^create /i) || query.match(/^drop table /i))
>              WebInspector.panels.storage.updateDatabaseTables(this.database);
> +
> +        if(!dataGrid)
> +            return;
> +

No need to move this code here, since its the end of the function anyways. The
code can just be deleted.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.