[Webkit-unassigned] [Bug 37743] Remove dependency of jsCurrentTime() on currentTime()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 17 14:05:40 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37743


Gavin Barraclough <barraclough at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53588|review?                     |review-
               Flag|                            |




--- Comment #5 from Gavin Barraclough <barraclough at apple.com>  2010-04-17 14:05:39 PST ---
(From update of attachment 53588)
This looks like a good fix, but I'm a little concerned about the existing
function continuing to be called 'currentTime', since it does not return the
current time!  'tickCount()', perhaps, or 'monotonicTime()'?  I'd suggest
having caught this bug it'd be really good to change the name of that function
(plus 'currentTimeMS' to match), to make its meaning a little clearer & prevent
similar problems in the future.

r- to this patch for chromium breakage.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list