[Webkit-unassigned] [Bug 37731] Integrate v8 testing utility with webkit tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37731


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53571|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #4 from Adam Barth <abarth at webkit.org>  2010-04-17 13:16:40 PST ---
(From update of attachment 53571)
+ os.system(' '.join(cmd))

os.system is a dangerous API.  Please consider using popen or
webkitpy.common.system.executive.

+ webkitRoot = os.path.join(os.path.dirname(__file__), '..', '..')

This seems very fragile.  Please consider using checkout_root in
webkitpy.common.checkout.scm.

+ workDir = tempfile.mkdtemp()

I don't understand why we need a working temp directory.  Can't we just
generate the new output into a memory buffer?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.