[Webkit-unassigned] [Bug 37741] New: Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37741

           Summary: Clean up
                    RenderPart/RenderPartObject/RenderFrame/RenderEmbedded
                    Object
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: simon.fraser at apple.com
                CC: cmarrin at apple.com


The class hierarchy for these renders is whacko:

           RenderPart
                |
       -------------------
      |                   |
      v                   V
RenderPartObject       RenderFrame
      |
      v
RenderEmbeddedObject

RenderEmbeddedObject is instantiated for plugins.
RenderFrame is instantiated for <frame>
RenderPartObject is instantiated for <iframe>

<frame> and <iframe> share some code in RenderPart, namely
RenderPart::layoutWithFlattening(), but this does not apply to plug-ins. Also,
most of the code in RenderPartObject only applies to iframes.

I think it should be:

           RenderPart
                |
       ----------------------
      |                      |
      v                      V
RenderEmbeddedObject    RenderFrameBase
                             |
                     ------------------
                    |                  |
                RenderFrame        RenderIFrame

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.