[Webkit-unassigned] [Bug 37428] [Qt] Patch to fix compilation warnings for QGraphicsWebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37428


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53355|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Simon Hausmann <hausmann at webkit.org>  2010-04-16 17:20:56 PST ---
(From update of attachment 53355)
> diff --git a/WebKit/qt/Api/qgraphicswebview.cpp b/WebKit/qt/Api/qgraphicswebview.cpp
> index 919a10a..b3bcbe7 100644
> --- a/WebKit/qt/Api/qgraphicswebview.cpp
> +++ b/WebKit/qt/Api/qgraphicswebview.cpp
> @@ -647,9 +647,13 @@ QVariant QGraphicsWebView::itemChange(GraphicsItemChange change, const QVariant&
>      case ItemCursorChange:
>          return value;
>      case ItemCursorHasChanged:
> -        QEvent event(QEvent::CursorChange);
> -        QApplication::sendEvent(this, &event);
> -        return value;
> +        {
> +            QEvent event(QEvent::CursorChange);
> +            QApplication::sendEvent(this, &event);
> +            return value;
> +        }

Coding style wants the opening brace on the line preceeding the code block.
Only function definitions have braces on lines of their own.

Otherwise LGTM of course.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.