[Webkit-unassigned] [Bug 37727] Webkit fixes for RVCT4

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37727


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hausmann at webkit.org




--- Comment #2 from Simon Hausmann <hausmann at webkit.org>  2010-04-16 14:31:45 PST ---
(In reply to comment #1)
> diff --git a/src/3rdparty/webkit/WebCore/page/qt/EventHandlerQt.cpp
> b/src/3rdparty/webkit/WebCore/page/qt/EventHandlerQt.cpp
> index d7982fa..2fcce5b 100644
> --- a/src/3rdparty/webkit/WebCore/page/qt/EventHandlerQt.cpp
> +++ b/src/3rdparty/webkit/WebCore/page/qt/EventHandlerQt.cpp
> @@ -51,7 +51,7 @@
>  #include "NotImplemented.h"
> 
>  QT_BEGIN_NAMESPACE
> -extern Q_GUI_EXPORT bool qt_tab_all_widgets; // from qapplication.cpp
> +Q_DECL_IMPORT extern bool qt_tab_all_widgets; // from qapplication.cpp

So this patch does two things:

    1) It removes the extern keyword

and

    2) It replaces Q_GUI_EXPORT with Q_DECL_IMPORT

AFAIK Q_GUI_EXPORT should be defined to Q_DECL_IMPORT in qglobal.h _unless_
we're building QtGui itself, which is not the case here.

Can you elaborate how your fix works? :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.